Onboarding #724

jmgasper · 2023-07-10T16:19:07Z

Related JIRA Ticket:
https://topcoder.atlassian.net/browse/MP-75

What's in this PR?

New onboarding app moving into dev

- onboarding app page 2/7

onboarding app page 1,2

… into onboarding

Onboarding update

Onboarding: work experience page and education page

onboarding: "+" button is disable for new user

- Next button on the Onboarding step 1 is not working

The entered data is not saved if the user clicks Back button in any step

…ui into onboarding

Onboarding : page 5,6

Minor onboarding issues

# Conflicts: # yarn.lock

Update onboarding to use new skill selector component

https://topcoder.atlassian.net/browse/MP-171

# Conflicts: # src/apps/profiles/src/config/constants.ts # src/apps/profiles/src/member-profile/community-awards/CommunityAwards.module.scss # src/apps/profiles/src/member-profile/education-and-certifications/EducationAndCertifications.module.scss # src/apps/profiles/src/member-profile/education-and-certifications/EducationCard/EducationCard.tsx # src/apps/profiles/src/member-profile/education-and-certifications/ModifyEducationModal/ModifyEducationModal.tsx # src/apps/profiles/src/member-profile/languages/MemberLanguages.tsx # src/apps/profiles/src/member-profile/page-layout/ProfilePageLayout.module.scss # src/apps/profiles/src/member-profile/page-layout/ProfilePageLayout.tsx # src/apps/profiles/src/member-profile/profile-header/ProfileHeader.module.scss # src/apps/profiles/src/member-profile/profile-header/ProfileHeader.tsx # src/apps/profiles/src/member-profile/skills/MemberSkillsInfo.module.scss # src/apps/profiles/src/member-profile/skills/MemberSkillsInfo.tsx # src/apps/profiles/src/member-profile/tc-achievements/MemberTCAchievements.tsx # src/apps/profiles/src/member-profile/work-expirence/ModifyWorkExpirenceModal/ModifyWorkExpirenceModal.tsx # src/apps/profiles/src/member-profile/work-expirence/WorkExpirence.module.scss # src/apps/profiles/src/member-profile/work-expirence/WorkExpirence.tsx # src/apps/profiles/src/member-profile/work-expirence/WorkExpirenceCard/WorkExpirenceCard.tsx # src/apps/profiles/src/profiles.routes.tsx # src/libs/ui/lib/components/form/form-groups/form-input/input-date-picker/InputDatePicker.tsx # yarn.lock

- Exiting out of onboarding flow takes the user to their profile

onboarding new design minor fix

kkartunov

Looks good!

vas3a

I'd suggest sticking with the eslint rules present into the codebase rather than disable them in every file. This brings inconsistency and was hoping to see some clean code if this is freshly implemented.

vas3a · 2023-07-10T16:42:22Z

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "vue.features.codeActions.enable": false


should remove this file probably

Ok, logging this, thanks.

vas3a · 2023-07-10T16:43:18Z

src/apps/onboarding/src/assets/images/back-green.svg

for icons, any reason for not using the HeroIcons? Some of these SVGs are matching the heroicons which are already included in the repo.

vas3a · 2023-07-10T16:44:33Z

src/apps/onboarding/src/components/DateInput/index.tsx

@@ -0,0 +1,97 @@
+/* eslint-disable ordered-imports/ordered-imports */


why all the eslint disable? is this DateInput component ported from somewhere else?
I know @kkartunov also has worked on a date input component for profile, could they be merged/reused?

@vas3a i only see one date input component in src/libs/ui/lib/components/form/form-groups/form-input/input-date-picker/InputDatePicker.tsx. I can not use that component for some reasons:

That component does not match with onboarding design

That component does not work well inside BaseModal (from '~/libs/ui')

@jmgasper should I use the existing component even if it does not match with the design?

@suppermancool - I'll let you know, but we can pause on this one.

@jmgasper @suppermancool There's no need to use it if it's too different or not compatible. Just want to make sure we're not adding components if we can use existing ones. thanks!

vas3a · 2023-07-10T16:45:00Z

src/apps/onboarding/src/components/FieldAvatar/index.tsx

@@ -0,0 +1,143 @@
+/* eslint-disable ordered-imports/ordered-imports */
+/* eslint-disable react/jsx-no-bind */
+/* eslint-disable react/destructuring-assignment */


again, why all the eslint disables?

vas3a · 2023-07-10T16:54:18Z

src/apps/onboarding/src/components/modal-add-work/index.tsx

+                        primary
+                        size='lg'
+                        label='save'
+                        onClick={() => {


should move the onclick handler into a named/callback function.

vas3a · 2023-07-10T16:54:41Z

src/apps/onboarding/src/components/modal-add-work/index.tsx

+                        name='company'
+                        label='Company *'
+                        value={workInfo.company}
+                        onChange={event => {


Test new skill selector integration in onboarding

Onboarding code cleanup

vas3a

Looks better! 🤞 thanks!

suppermancool and others added 30 commits June 22, 2023 18:39

- onboarding app page 1/7

5bf28b1

- onboarding app page 2/7

Merge pull request #668 from topcoder-platform/issue-659

9a8b7d4

onboarding app page 1,2

Merge branch 'onboarding' of github.com:topcoder-platform/platform-ui…

fb6ae72

… into onboarding

Deploy onboarding to dev

7eaa80d

Onboarding update

9885820

Merge pull request #669 from topcoder-platform/issue-659

e127b03

Onboarding update

Force member login for onboarding

2e6fe88

Onboarding: work experience page and education page

4dbb2e0

fix date picker placeholder color

d262eba

Merge pull request #670 from topcoder-platform/issue-661

9fe8c10

Onboarding: work experience page and education page

onboarding: "+" button is disable for new user

e1618f2

Merge branch 'onboarding' into issue-661

796f12c

Merge pull request #671 from topcoder-platform/issue-661

6bb73da

onboarding: "+" button is disable for new user

- Remove Linked In buttons and references

9ccefd9

- Next button on the Onboarding step 1 is not working

Merge pull request #676 from topcoder-platform/issue-675

eb005f1

The entered data is not saved if the user clicks Back button in any step

8221660

Merge branch 'onboarding' into issue-675

0491212

Merge pull request #681 from topcoder-platform/issue-675

1c4a31d

The entered data is not saved if the user clicks Back button in any step

Onboarding - Input a bio and profile picture

5542a84

Merge branch 'onboarding' into issue-675

1ee3fdf

Merge branch 'profiles-app' of github.com:topcoder-platform/platform-…

67ec5f9

…ui into onboarding

Onboarding: page 5,6/7

1b48f50

Merge branch 'onboarding' into issue-675

70e468b

Onboarding: page 5,6/7

eb75c69

Merge pull request #682 from topcoder-platform/issue-675

f607755

Onboarding : page 5,6

Minor onboarding issues

46649bd

Merge pull request #693 from topcoder-platform/issue-686

7d3794a

Minor onboarding issues

Merge branch 'skill-selector-input' into onboarding

0d5a14f

# Conflicts: # yarn.lock

Merge pull request #699 from topcoder-platform/issue-698

0d9c556

Update onboarding to use new skill selector component

Remove the "welcome to Topcoder" app name

1d8069a

https://topcoder.atlassian.net/browse/MP-171

jmgasper and others added 13 commits July 5, 2023 13:32

Let’s try this instead

445f4f1

- Change number of onboarding steps from 7 to 6

573bc1b

- Exiting out of onboarding flow takes the user to their profile

Merge pull request #707 from topcoder-platform/issue-705-706

21ebe85

New onboarding look and feel

fa70d2f

Merge pull request #713 from topcoder-platform/issues-708-to-712

793163a

update onboarding ui

b54573b

onboarding fix wrong text

e47ec60

onboarding: fix final step link

954d22e

Merge pull request #714 from topcoder-platform/issues-708-to-712

ec62f72

onboarding new design minor fix

4fb167e

Merge pull request #715 from topcoder-platform/issue-709

b3c0065

onboarding new design minor fix

Merge branch 'dev' into onboarding

828ad1f

jmgasper requested a review from kkartunov July 10, 2023 16:19

kkartunov approved these changes Jul 10, 2023

View reviewed changes

vas3a requested review from kkartunov and vas3a July 10, 2023 16:46

vas3a requested changes Jul 10, 2023

View reviewed changes

Merge branch 'EMSI-skill-editor' into onboarding

3313bb2

jmgasper mentioned this pull request Jul 10, 2023

Onboarding code cleanup #726

Closed

suppermancool and others added 4 commits July 11, 2023 00:40

Test new skill selector integration in onboarding

24238be

Merge pull request #727 from topcoder-platform/issue-725

9acfb5d

Test new skill selector integration in onboarding

Onboarding code cleanup

a48a8cd

Merge pull request #728 from topcoder-platform/issue-725

bbf2b88

Onboarding code cleanup

vas3a approved these changes Jul 10, 2023

View reviewed changes

jmgasper merged commit 98a1acf into dev Jul 10, 2023

		@@ -0,0 +1,97 @@
		/* eslint-disable ordered-imports/ordered-imports */

Onboarding #724

Onboarding #724

Uh oh!

Conversation

jmgasper commented Jul 10, 2023

What's in this PR?

Uh oh!

kkartunov left a comment

Choose a reason for hiding this comment

Uh oh!

vas3a left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vas3a left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants