Skip to content

Conversation

@vas3a
Copy link
Collaborator

@vas3a vas3a commented Jul 11, 2023

Related JIRA Ticket:
https://topcoder.atlassian.net/browse/LVT-134

What's in this PR?

Cleans up env variables
Converts REACT_APP_ env variables to boolean/number/null as needed.

@vas3a vas3a requested review from kkartunov and testflyjets July 11, 2023 21:36
@vas3a vas3a self-assigned this Jul 11, 2023
@vas3a vas3a requested review from kkartunov and testflyjets July 12, 2023 06:56
@vas3a
Copy link
Collaborator Author

vas3a commented Jul 12, 2023

@testflyjets @kkartunov I updated the scripts in package.json to rely on LOGICAL_ENV (exposed by CircleCI hopefully) for the build mode.

…env-vars

Changes CircleCI env var handling
@vas3a vas3a merged commit 7f981b4 into dev Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants