Skip to content

fix env types conversion -> dev #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix env types conversion -> dev #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/config/environments/react-env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,28 @@

export function getReactEnv<T>(varName: string, defaultValue?: string | boolean | number): T {
const hasDefaultValue: boolean = arguments.length > 1

let value = process.env[`REACT_APP_${varName}`] as unknown as T

if (value === undefined && !hasDefaultValue) {
throw new Error(`${varName} is not defined in process.env!`)
}

// convert to boolean
if (value === 'false' || value === 'true') {
value = (value === 'true' as unknown) as T
// convert to number
if (!Number.isNaN(Number(value))) {
value = Number(value as unknown) as T
}

// convert to null
if (value === 'null') {
value = (null as unknown) as T
// return early as the bottom expresion will just return the "default value"
return value
}

// convert to number
if (!Number.isNaN(Number(value))) {
value = (null as unknown) as T
// convert to boolean
if (value === 'false' || value === 'true') {
value = (value === 'true' as unknown) as T
}

return (value ?? defaultValue) as T
Expand Down