Skip to content

Tweak how skills work text #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2023
Merged

Tweak how skills work text #886

merged 2 commits into from
Aug 11, 2023

Conversation

@jmgasper
Copy link
Collaborator

TAL-48

Related JIRA Ticket:
https://topcoder.atlassian.net/browse/TAL-48

@jmgasper jmgasper requested a review from kkartunov August 11, 2023 06:11
kkartunov
kkartunov requested changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also handle this as well:

platform-ui/src/libs/shared/lib/components/modals/how-skills-work-modal/HowSkillsWorkModal.tsx

Line 71 in 50136f9

Experts can also self-proclaim skills that have not yet been proven.

kkartunov
kkartunov approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jmgasper jmgasper merged commit 00bc9e3 into dev Aug 11, 2023
@vas3a vas3a deleted the TAL-48 branch August 11, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkartunov kkartunov kkartunov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmgasper @kkartunov