Skip to content

Talent search fixes -> dev #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Talent search fixes -> dev #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e9de3d
TAL-45 - add message when there are no results in talent search
vas3a Aug 11, 2023
2f08326
TAL-47 - fix search input & responsiveness
vas3a Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/apps/talent-search/src/routes/search-results-page/SearchResultsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ const SearchResultsPage: FC = () => {
<span>
Search thousands of skills to match with our global experts.
</span>
) : !total ? (
<span>
Reach out to Topcoder to find the right member for you.
</span>
) : (
<>
{skillsModalTriggerBtn}
Expand Down
4 changes: 4 additions & 0 deletions src/libs/ui/lib/components/content-layout/ContentLayout.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
display: flex;
flex-direction: column;

@include ltesm {
max-width: 100%;
}

.page-header {
display: flex;
align-items: center;
Expand Down
13 changes: 3 additions & 10 deletions ...lib/components/form/form-groups/form-input/input-multiselect/InputMultiselect.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@
}
}

.additionalPlaceholder {
color: $black-60;
width: 0;
pointer-events: none;
white-space: nowrap;
}

.multiselect .ms {
display: block;

Expand Down Expand Up @@ -88,6 +81,9 @@
padding: 0;
visibility: visible;
order: 999;
> input {
min-width: 72px!important;
}
}

&:global(__multi-value) {
Expand Down Expand Up @@ -175,9 +171,6 @@
color: $tc-white;
}
}
&:global(__input-container):focus-within + .additionalPlaceholder {
display: none;
}
}

.theme-clear.multiselect .ms {
Expand Down
24 changes: 11 additions & 13 deletions ...libs/ui/lib/components/form/form-groups/form-input/input-multiselect/InputMultiselect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,25 +64,23 @@ const MultiValueRemove: FC = (props: any) => (
</components.MultiValueRemove>
)

const Input: FC = (props: any) => {
const placeholder = props.hasValue && props.selectProps.isSearchable
? props.selectProps.placeholder
: ''

return (
<components.Input {...props} placeholder={placeholder} />
)
}

// eslint-disable-next-line react/function-component-definition
const dropdownIndicator = (dropdownIcon: ReactNode): FC => (props: any) => (
<components.DropdownIndicator {...props}>
{dropdownIcon}
</components.DropdownIndicator>
)

// eslint-disable-next-line react/function-component-definition
const ValueContainer = (props: any): JSX.Element => (
<components.ValueContainer {...props}>
{props.children}
{props.hasValue && props.selectProps.isSearchable && (
<span className={classNames('body-small', styles.additionalPlaceholder)}>
{props.selectProps.placeholder}
</span>
)}
</components.ValueContainer>
)

const InputMultiselect: FC<InputMultiselectProps> = props => {
const asynSelectRef = useRef<any>()
const placeholder = useMemo(() => (
Expand Down Expand Up @@ -149,8 +147,8 @@ const InputMultiselect: FC<InputMultiselectProps> = props => {
isSearchable={isSearchable}
components={{
DropdownIndicator: dropdownIndicator(props.dropdownIcon),
Input,
MultiValueRemove,
ValueContainer,
}}
value={props.value}
openMenuOnClick={false}
Expand Down