PROD-4398 integrate userflow remove sprig -> dev #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testflyjets
reviewed
Oct 2, 2023
| } | ||
|
|
||
| export const SPRIG_CES_SURVEY_ID = 'onProfileUpdate' | ||
| export const CES_SURVEY_ID = '5cfae36f-0700-41c4-8938-0add4037acb2' |
There was a problem hiding this comment.
If this ID is specific to a particular Userflow survey, should we be injecting it as an env var at build time instead of directly in code?
There was a problem hiding this comment.
@testflyjets I'll update them as env values, makes more sense, I missed it 👍
testflyjets
reviewed
Oct 2, 2023
| @@ -1,2 +1,2 @@ | |||
| export const SPRIG_CES_SURVEY_ID = 'onTalentSearchResults' | |||
| export const CES_SURVEY_ID = 'd1030c93-dd36-4ae0-b5d0-95004b8e9d32' | |||
There was a problem hiding this comment.
Should this be in an env var?
testflyjets
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PROD-4398
What's in this PR?
Removes SPRIG integrations.
Triggers userflow surveys via the new uninav method
triggerSurvey