Skip to content

Update to use non-deleted IDs #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update to use non-deleted IDs #930

merged 2 commits into from
Oct 17, 2023

Conversation

jmgasper
Copy link
Collaborator

Related to Slack convo RE: deleted skills.

kkartunov
kkartunov requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmgasper would you please also update the names to match those as in the standardized skills table?

testflyjets
testflyjets approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the IDs are correct.

@jmgasper
Copy link
Collaborator Author

@jmgasper would you please also update the names to match those as in the standardized skills table?

Done

@jmgasper jmgasper merged commit 7e1250c into feature/standardized-skills Oct 17, 2023
@kkartunov kkartunov deleted the fix_popular_skill_ids branch October 18, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkartunov kkartunov kkartunov requested changes

+1 more reviewer

@testflyjets testflyjets testflyjets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmgasper @testflyjets @kkartunov