Skip to content

fix: wallet app fixes and improvements (core-96) #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 15, 2024
Merged

fix: wallet app fixes and improvements (core-96) #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08f0231
fix: transaction id is not required when removing payment provider
rakibansary Feb 15, 2024
726f470
Merge pull request #956 from topcoder-platform/CORE-96-1
rakibansary Feb 15, 2024
81ee52d
fix: add task payment in category/type filter
rakibansary Feb 15, 2024
9028631
Merge pull request #957 from topcoder-platform/CORE-96-1
rakibansary Feb 15, 2024
b54765c
fix: instructions link
rakibansary Feb 15, 2024
0ef2d21
Merge pull request #958 from topcoder-platform/CORE-310
rakibansary Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/apps/wallet/src/home/tabs/payments/PaymentsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,6 @@ const PaymentsTab: FC = () => {
}
}}
onRemoveProvider={async function onRemoveProvider() {
const transactionId = selectedPaymentProvider.transactionId
if (transactionId === undefined) {
toast.error(
'Something went wrong. Please try again.',
{ position: toast.POSITION.BOTTOM_RIGHT },
)
return
}

try {
// eslint-disable-next-line max-len
const response: TransactionResponse = await removePaymentProvider(selectedPaymentProvider.type)
Expand Down
2 changes: 1 addition & 1 deletion src/apps/wallet/src/home/tabs/tax-forms/TaxFormsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const TAX_FORM_DETAILS = [
icon: <IconWorld />,
id: 'W-8BEN-E',
instructionsLabel: 'Instructions',
instructionsLink: 'https://www.irs.gov/pub/irs-pdf/iw8ben.pdf',
instructionsLink: 'https://www.irs.gov/pub/irs-pdf/iw8bene.pdf',
reasonDescription:
// eslint-disable-next-line max-len
'Under current IRS guidance, foreign persons performing services outside of the U.S. are not subject to income tax withholding. However, Topcoder requires all such members to provide a properly filled out W-8BEN-E prior to issuing payment. In addition, prize money paid to foreign persons who are not performing services (such as winning an SRM competition) is subject to withholding taxes.',
Expand Down
4 changes: 4 additions & 0 deletions src/apps/wallet/src/home/tabs/winnings/WinningsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ const ListView: FC<ListViewProps> = (props: ListViewProps) => {
key: 'type',
label: 'Type',
options: [
{
label: 'Task Payment',
value: 'TASK_PAYMENT',
},
{
label: 'Contest Payment',
value: 'CONTEST_PAYMENT',
Expand Down