-
Notifications
You must be signed in to change notification settings - Fork 9
PM-2213 - fetch workflowRun attachments #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Very good solution of uising streams and piping the response.
Let's fix minor comments and we done here...
@ApiOperation({ | ||
summary: 'List all attachments linked to the specific run', | ||
}) | ||
@ApiParam({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shall have a @ApiParam
for workflowId
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ApiOperation({ | ||
summary: 'Download an attachment archive linked to the specific run', | ||
}) | ||
@ApiParam({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again we need to add workflowId and runId to docs call signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kkartunov in the new swagger version, these annotations are used only to add description.
When you use @Param('workflowId') workflowId: string,
in the method signature, they're automatically added to swagger as inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://topcoder.atlassian.net/browse/PM-2213 - GET /workflows/{workflowId}/runs/{runId}/attachments
https://topcoder.atlassian.net/browse/PM-2217 - GET /workflows/{workflowId}/runs/{runId}/attachments/{artifactId}/zip