Performance tweaks for large account in prod #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| -- Add a composite index to speed up paginated lookups by review item | |||
| CREATE INDEX IF NOT EXISTS "reviewItemComment_reviewItemId_sortOrder_id_idx" | |||
There was a problem hiding this comment.
[performance]
Consider verifying that the order of columns in the composite index aligns with the query patterns used in the application. The order can significantly impact the performance of the index.
…t from legacy data
| @@ -0,0 +1,3 @@ | |||
| -- Add isFileSubmission flag to submissions to differentiate file vs URL entries | |||
| ALTER TABLE "submission" | |||
| ADD COLUMN IF NOT EXISTS "isFileSubmission" BOOLEAN NOT NULL DEFAULT false; | |||
There was a problem hiding this comment.
[performance]
Consider adding an index on the isFileSubmission column if this field will be frequently queried or filtered on. This can improve query performance, especially on large datasets.
| @UploadedFile() file: Express.Multer.File, | ||
| @Body() body: SubmissionRequestDto, | ||
| ): Promise<SubmissionResponseDto> { | ||
| console.log( |
There was a problem hiding this comment.
[maintainability]
Using console.log for logging is not recommended in production code. Consider using the LoggerService for consistent logging and to take advantage of any logging infrastructure in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.