Skip to content

Performance updates #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
Merged

Performance updates #134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
068eb91
More performance updates
jmgasper Nov 1, 2025
0ec7859
Merge pull request #133 from topcoder-platform/performance
jmgasper Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/api/my-review/myReview.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export class MyReviewService {
whereFragments.push(Prisma.sql`c.status = 'ACTIVE'`);
}

const joins: Prisma.Sql[] = [];
const baseJoins: Prisma.Sql[] = [];

if (!adminUser) {
if (!normalizedUserId) {
Expand All @@ -165,7 +165,7 @@ export class MyReviewService {
);
}

joins.push(
baseJoins.push(
Prisma.sql`
LEFT JOIN resources."Resource" r
ON r."challengeId" = c.id
Expand All @@ -177,7 +177,7 @@ export class MyReviewService {

whereFragments.push(Prisma.sql`r."challengeId" IS NOT NULL`);
} else {
joins.push(
baseJoins.push(
Prisma.sql`
LEFT JOIN resources."Resource" r
ON r."challengeId" = c.id
Expand All @@ -188,10 +188,13 @@ export class MyReviewService {
);
}

joins.push(
baseJoins.push(
Prisma.sql`
LEFT JOIN challenges."ChallengeType" ct ON ct.id = c."typeId"
`,
);

const metricJoins: Prisma.Sql[] = [
Prisma.sql`
LEFT JOIN LATERAL (
SELECT
Expand Down Expand Up @@ -279,7 +282,7 @@ export class MyReviewService {
AND apr."resourceId" = r.id
WHERE rv_pending."resourceId" = r.id
AND apr.id IS NULL
) AS "hasPendingAppealResponses"
) AS "hasPendingAppealResponses"
) pending_appeals ON TRUE
`,
Prisma.sql`
Expand Down Expand Up @@ -309,7 +312,13 @@ export class MyReviewService {
) AS "hasAIReview"
) cr ON TRUE
`,
];

const joinClause = joinSqlFragments(
[...baseJoins, ...metricJoins],
Prisma.sql``,
);
const countJoinClause = joinSqlFragments(baseJoins, Prisma.sql``);

if (challengeTypeId) {
whereFragments.push(Prisma.sql`c."typeId" = ${challengeTypeId}`);
Expand All @@ -331,7 +340,6 @@ export class MyReviewService {
);
}

const joinClause = joinSqlFragments(joins, Prisma.sql``);
const whereClause = joinSqlFragments(whereFragments, Prisma.sql` AND `);

const phaseEndExpression = Prisma.sql`
Expand Down Expand Up @@ -410,7 +418,7 @@ export class MyReviewService {
const countQuery = Prisma.sql`
SELECT COUNT(DISTINCT c.id) AS "total"
FROM challenges."Challenge" c
${joinClause}
${countJoinClause}
WHERE ${whereClause}
`;

Expand Down