Additional performance tweaks #139
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| LIMIT 1 | ||
| ) AS "incompletePhaseName" | ||
| ) deliverable_reviews ON TRUE | ||
| ) deliverable_reviews ON r.id IS NOT NULL |
There was a problem hiding this comment.
[❗❗ correctness]
The change from ON TRUE to ON r.id IS NOT NULL modifies the join condition, potentially altering the result set. Ensure that this change aligns with the intended logic and does not inadvertently exclude rows that should be included.
| AND apr.id IS NULL | ||
| ) AS "hasPendingAppealResponses" | ||
| ) pending_appeals ON TRUE | ||
| ) pending_appeals ON r.id IS NOT NULL |
There was a problem hiding this comment.
[❗❗ correctness]
Similar to the change on line 284, altering the join condition from ON TRUE to ON r.id IS NOT NULL could affect the result set. Verify that this change is intentional and does not exclude necessary rows.
| WHERE cr."challengeId" = c.id | ||
| AND cr."aiWorkflowId" is not NULL | ||
| ) AS "hasAIReview" | ||
| TRUE AS "hasAIReview" |
There was a problem hiding this comment.
[❗❗ correctness]
Replacing the EXISTS subquery with TRUE changes the logic of determining hasAIReview. This could lead to incorrect data being returned if the presence of AI reviews is not properly checked. Ensure this change is intentional and correctly reflects the business logic.
No description provided.