Skip to content

Further performance updates #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
Merged

Further performance updates #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2997cf
Additional performance tweaks
jmgasper Nov 1, 2025
641df60
Merge pull request #139 from topcoder-platform/performance
jmgasper Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/api/my-review/myReview.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export class MyReviewService {
cp_incomplete.name ASC
LIMIT 1
) AS "incompletePhaseName"
) deliverable_reviews ON TRUE
) deliverable_reviews ON r.id IS NOT NULL
Copy link

@github-actions github-actions bot Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Changing the join condition from ON TRUE to ON r.id IS NOT NULL may alter the behavior of the query, especially if r.id can be NULL. Ensure that this change aligns with the intended logic and does not inadvertently exclude rows that should be included.

`,
Prisma.sql`
LEFT JOIN LATERAL (
Expand All @@ -301,7 +301,7 @@ export class MyReviewService {
WHERE rv_pending."resourceId" = r.id
AND apr.id IS NULL
) AS "hasPendingAppealResponses"
) pending_appeals ON TRUE
) pending_appeals ON r.id IS NOT NULL
Copy link

@github-actions github-actions bot Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Similar to the previous change, updating the join condition from ON TRUE to ON r.id IS NOT NULL could impact the query results. Verify that this modification is intentional and that it correctly reflects the desired logic.

`,
Prisma.sql`
LEFT JOIN LATERAL (
Expand All @@ -322,12 +322,11 @@ export class MyReviewService {
Prisma.sql`
LEFT JOIN LATERAL (
SELECT
EXISTS (
SELECT 1
FROM challenges."ChallengeReviewer" cr
WHERE cr."challengeId" = c.id
AND cr."aiWorkflowId" is not NULL
) AS "hasAIReview"
TRUE AS "hasAIReview"
Copy link

@github-actions github-actions bot Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Replacing the EXISTS check with TRUE AS "hasAIReview" changes the logic to always return TRUE, regardless of whether there is an AI review. This could lead to incorrect data representation. Confirm that this change is intended and that it does not misrepresent the presence of AI reviews.

FROM challenges."ChallengeReviewer" cr
WHERE cr."challengeId" = c.id
AND cr."aiWorkflowId" IS NOT NULL
LIMIT 1
) cr ON TRUE
`,
];
Expand Down