Skip to content

Additional tweak for past-challenges on my-reviews for large / admin accounts #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
Merged

Additional tweak for past-challenges on my-reviews for large / admin accounts #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c56c08
Additional tweak for past-challenges on my-reviews for large / admin …
jmgasper Nov 2, 2025
8a69493
Merge pull request #145 from topcoder-platform/performance
jmgasper Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/api/my-review/myReview.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,10 +533,13 @@ export class MyReviewService {
break;
}

const fallbackOrderFragments = [
Prisma.sql`c."createdAt" DESC NULLS LAST`,
Prisma.sql`c.name ASC`,
];
const fallbackOrderFragments = shouldFetchPastChallenges
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The change introduces a conditional assignment to fallbackOrderFragments based on shouldFetchPastChallenges. Ensure that shouldFetchPastChallenges is correctly determined earlier in the code to avoid unexpected ordering behavior.

? [
Prisma.sql`c."endDate" DESC NULLS LAST`,
Prisma.sql`c."createdAt" DESC NULLS LAST`,
Prisma.sql`c.name ASC`,
]
: [Prisma.sql`c."createdAt" DESC NULLS LAST`, Prisma.sql`c.name ASC`];
const orderFragments = sortFragments.length
? [...sortFragments, ...fallbackOrderFragments]
: fallbackOrderFragments;
Expand Down