fix(PM-2177): Send comment creator details and changes comments structure #172
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - pm-1955_2 | ||
| - re-try-failed-jobs | ||
| - pm-2539 | ||
| - pm-2177_user_detais |
There was a problem hiding this comment.
[❗❗ correctness]
There is a typo in the branch name pm-2177_user_detais. It should likely be pm-2177_user_details. This could lead to confusion or errors when triggering workflows based on branch names.
| .map((item) => item.createdBy as string); | ||
|
|
||
| const members = await this.memberPrisma.member.findMany({ | ||
| where: { userId: { in: createdByList.map((id) => BigInt(id)) } }, |
There was a problem hiding this comment.
[❗❗ correctness]
Using BigInt to convert userId might cause issues if createdByList contains non-numeric strings. Consider validating the input before conversion to ensure all entries are valid numeric strings.
| }); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-return | ||
| const normalized = members.map((m: any) => ({ |
There was a problem hiding this comment.
[maintainability]
The use of any type for members and commentsById can lead to runtime errors due to lack of type safety. Consider defining a specific type or interface for these objects to improve type safety and maintainability.
| for (const item of items) { | ||
| for (const comment of item.comments) { | ||
| if (comment.parentId) { | ||
| const parent = commentsById[comment.parentId]; |
There was a problem hiding this comment.
[performance]
The nested loop structure for reconstructing comments could be optimized. Consider using a single pass to build the commentsById map and nest child comments, which would improve performance by reducing the complexity from O(n^2) to O(n).
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-2177