#73 Fix error while creating a review application #88
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Create a mock request object with the authorization header | ||
| const mockReq = { | ||
| // Create a request object with the authorization header | ||
| const req = { |
There was a problem hiding this comment.
Consider renaming req to something more descriptive, such as authRequest, to clarify its purpose and distinguish it from other potential request objects.
| }; | ||
|
|
||
| const mockRes = {}; | ||
| const res = {}; |
There was a problem hiding this comment.
Consider renaming the variable res to something more descriptive to clarify its purpose and usage within the code.
|
|
||
| // Call the tc-core-library-js authenticator | ||
| this.jwtAuthenticator(mockReq, mockRes, next); | ||
| this.jwtAuthenticator(req, res, next); |
There was a problem hiding this comment.
The change from mockReq and mockRes to req and res suggests that the actual request and response objects are now being used. Ensure that req and res are correctly initialized and contain the expected properties before passing them to jwtAuthenticator. This change might affect how the authenticator processes the request and response, so verify that it behaves as intended with real objects.
2 participants
Root cause: The tc-core-library-js (used for JWT validation) was adding the decoded JWT payload fields directly, including userId: 40158767 as a number, while the database schema requires all user IDs to be strings.