Skip to content

PM-2595 - handle challenge canceled due to failed review #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

PM-2595 - handle challenge canceled due to failed review #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/dto/challenge.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
export const ChallengeStatuses = {
New: "New",
Active: "Active",
Draft: "Draft",
Approved: "Approved",
Canceled: "Canceled",
Completed: "Completed",
Deleted: "Deleted",
CancelledFailedReview: "Cancelled - Failed Review",
CancelledFailedScreening: "Cancelled - Failed Screening",
CancelledZeroSubmissions: "Cancelled - Zero Submissions",
CancelledWinnerUnresponsive: "Cancelled - Winner Unresponsive",
CancelledClientRequest: "Cancelled - Client Request",
CancelledRequirementsInfeasible: "Cancelled - Requirements Infeasible",
CancelledZeroRegistrations: "Cancelled - Zero Registrations",
CancelledPaymentFailed: "Cancelled - Payment Failed",
New: 'New',
Active: 'Active',
Draft: 'Draft',
Approved: 'Approved',
Canceled: 'Canceled',
Completed: 'Completed',
Deleted: 'Deleted',
CancelledFailedReview: 'CANCELLED_FAILED_REVIEW',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
Consider using a consistent naming convention for all status keys. The new keys use uppercase with underscores (e.g., CANCELLED_FAILED_REVIEW), while the existing ones use PascalCase (e.g., New, Active). This inconsistency could lead to confusion and potential errors in usage.

CancelledFailedScreening: 'CANCELLED_FAILED_SCREENING',
CancelledZeroSubmissions: 'CANCELLED_ZERO_SUBMISSIONS',
CancelledWinnerUnresponsive: 'CANCELLED_WINNER_UNRESPONSIVE',
CancelledClientRequest: 'CANCELLED_CLIENT_REQUEST',
CancelledRequirementsInfeasible: 'CANCELLED_REQUIREMENTS_INFEASIBLE',
CancelledZeroRegistrations: 'CANCELLED_ZERO_REGISTRATIONS',
CancelledPaymentFailed: 'CANCELLED_PAYMENT_FAILED',
};