Skip to content

Conversation

@maxceem
Copy link
Contributor

@maxceem maxceem commented Jan 30, 2019

This is the PR with a winning submission for the challenge https://www.topcoder.com/challenges/30081357

The implementation looks very good. The only one requirement which was missed is filter query param should be mandatory, together with orgId property.

Though as it's a small requirement which is easy to fix. To not wait for another round as it's participants night now, and other than that the submission looks perfect.

Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrohit vikasrohit merged commit e889c24 into dev Jan 30, 2019
@eisbilir eisbilir deleted the feature/org-configs branch November 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants