Skip to content

Fix for Issue #323 #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

Fix for Issue #323 #337

merged 1 commit into from
Jul 8, 2019

Conversation

@gets0ul
Copy link
Contributor

@gets0ul gets0ul commented Jul 7, 2019

#323

Update code to NOT pass transactions explicitly.

@gets0ul gets0ul mentioned this pull request Jul 7, 2019
Closed
@maxceem maxceem self-requested a review July 8, 2019 09:18
maxceem
maxceem approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gets0ul for the demo video, they are super clear.

Update without transactions works good.

@maxceem maxceem merged commit d9c94ef into topcoder-platform:cf18 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maxceem maxceem maxceem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gets0ul @maxceem