feat(PM-1510): Send Email notification to PM/creator once copilot accepts invite #839

hentrymartin · 2025-07-28T21:18:26Z

What's in this PR?

Send Email notification to PM/creator once copilot accepts invite

Ticket link - https://topcoder.atlassian.net/browse/PM-1510

…member

…r customer

github-actions · 2025-07-28T21:49:18Z

src/routes/projectMemberInvites/update.js

+                      });
+                    }
+
                    await t.commit();


Consider adding error handling for the t.commit() operation to ensure that any issues during the commit process are properly caught and managed. This will help prevent potential issues if the commit fails.

github-actions · 2025-07-28T21:49:21Z

src/routes/projectMembers/update.js

+
+  req.log.debug(`updated all copilot applications`);
+
+  await _transaction.commit();


Consider adding error handling around the _transaction.commit() call to ensure that any issues during the commit process are properly managed. This could help prevent potential data inconsistencies or application crashes.

github-actions · 2025-07-28T21:49:23Z

src/routes/projectMembers/update.js

    updatedProps = _.pick(updatedProps, ['isPrimary', 'role']);
    const fields = req.query.fields ? req.query.fields.split(',') : null;

    let previousValue;


Consider using await with models.ProjectMember.findOne since the transaction function is now asynchronous. This will ensure that the promise is resolved before proceeding.

github-actions · 2025-07-28T21:49:25Z

src/routes/projectMembers/update.js

      })
-      .catch(err => next(err)));
+      .catch(async (err) => {
+        await _transaction.rollback();


Consider checking the result of _transaction.rollback() for errors or exceptions to ensure that the rollback was successful.

github-actions · 2025-07-28T22:09:24Z

src/routes/projectMemberInvites/update.js

+                            return false;
+                          }
+
+                          return item.email.toLowerCase() === creator.email.toLowerCase();


The variable creator is being accessed as an object instead of an array. Ensure that creator is always an object and not an array to avoid runtime errors.

github-actions · 2025-07-28T22:35:41Z

src/routes/projectMemberInvites/update.js

+
+                      const opportunity = await models.CopilotOpportunity.findOne({
+                        where: {
+                          id: application.opportunityId,


Consider adding a null check for application before accessing application.opportunityId to prevent potential runtime errors if application is not found.

github-actions · 2025-07-28T22:35:41Z

src/routes/projectMemberInvites/update.js

+                        where: {
+                          id: application.opportunityId,
+                        },
+                        include: [


Consider adding error handling for the database query to ensure that any issues with fetching the opportunity are properly managed.

github-actions · 2025-07-28T22:35:44Z

src/routes/projectMemberInvites/update.js

+                      const creator = userDetails[0];
+                      const invitee = userDetails[1];
+                      const listOfSubjects = subjects;
+                      if (creator && creator.email) {


The variable application is removed but is still referenced in the code. Ensure that the removal of this variable does not affect other parts of the code that might rely on it.

github-actions · 2025-07-28T22:35:44Z

src/routes/projectMemberInvites/update.js

+                            return false;
+                          }
+
+                          return item.email.toLowerCase() === creator.email.toLowerCase();


The variable opportunity is removed but is still referenced in the code. Ensure that the removal of this variable does not affect other parts of the code that might rely on it.

github-actions · 2025-07-28T23:05:59Z

src/routes/projectMemberInvites/update.js

+                      const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id);
+
+                      const creatorDetails = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id);
+                      const inviteeDetails = await util.getMemberDetailsByUserIds([application.userId], req.log, req.id);


The variable inviteeDetails is assigned using application.userId, but the previous code used invite.userId. Ensure that application.userId is the correct identifier for the invitee in this context.

github-actions · 2025-07-29T16:52:38Z

src/routes/projectMembers/update.js

  },
 };

+const completeAllCopilotRequests = async (req, projectId, _transaction, _member) => {


The _member parameter is added to the function signature but is not used within the function body. Consider removing it if it's not needed, or ensure it is utilized appropriately.

github-actions · 2025-07-29T16:52:40Z

src/routes/projectMembers/update.js

+
+  await _transaction.commit();
+
+  const memberDetails = await util.getMemberDetailsByUserIds([_member.userId], req.log, req.id);


Consider checking if _member is defined before accessing userId to avoid potential runtime errors.

github-actions · 2025-07-29T16:52:40Z

src/routes/projectMembers/update.js

+
+    req.log.debug(`Copilot request data: ${requestData}`);
+    const opportunity = copilotOpportunites.find(item => item.copilotRequestId === request.id);
+


Ensure opportunity is defined before accessing opportunity.id to prevent errors if find returns undefined.

github-actions · 2025-07-29T16:52:40Z

src/routes/projectMembers/update.js

+        user_name: memberDetails ? memberDetails.handle : "",
+      },
+      sendgrid_template_id: TEMPLATE_IDS.COPILOT_ALREADY_PART_OF_PROJECT,
+      recipients: [memberDetails.email],


Consider verifying that memberDetails.email is defined before using it as a recipient to avoid sending emails to undefined.

github-actions · 2025-07-29T16:52:43Z

src/routes/projectMembers/update.js

-      .then(() => {
+      .then(async () => {
        projectMember = projectMember.get({ plain: true });
        projectMember = _.omit(projectMember, ['deletedAt']);


The function completeAllCopilotRequests now has an additional parameter _member. Ensure that this parameter is necessary for the function's operation and that the function definition is updated accordingly to handle this new argument.

github-actions · 2025-07-29T17:01:11Z

src/routes/projectMembers/update.js

+    transaction: _transaction,
+  });
+
+  // If the invited member


Consider adding error handling for the case when memberApplication is not found or the update fails. This will help ensure that the application status update process is robust and can handle unexpected scenarios gracefully.

github-actions · 2025-07-29T17:01:11Z

src/routes/projectMembers/update.js

+    });
+  }
+
+  req.log.debug(`updated all copilot applications`);


The log message updated all copilot applications might be misleading since the update operation for memberApplication is separate from allCopilotApplications. Consider revising the log message to accurately reflect the operations performed.

github-actions · 2025-07-29T18:34:26Z

src/routes/projectMembers/update.js

+        if ((updatedProps.role === previousValue.role || action === 'complete-copilot-requests') &&
              (_.isUndefined(updatedProps.isPrimary) ||
                updatedProps.isPrimary === previousValue.isPrimary)) {
+          await completeAllCopilotRequests(req, projectId, _transaction, _member);


The function completeAllCopilotRequests now has an additional parameter _member. Ensure that this change is reflected in the function definition and that _member is being used appropriately within the function. If _member is not needed, consider removing it to maintain clarity and simplicity.

github-actions · 2025-07-29T19:30:26Z

src/routes/projectMembers/update.js

+
+  req.log.debug(`updated all copilot applications`);
+
+  const memberDetails = await util.getMemberDetailsByUserIds([_member.userId], req.log, req.id);


The removal of _transaction.commit() might lead to uncommitted changes in the database. Ensure that the transaction is being committed elsewhere or that this removal is intentional and safe.

github-actions · 2025-07-29T20:24:24Z

src/routes/projectMembers/update.js

+  const allCopilotRequests = await models.CopilotRequest.findAll({
+    where: {
+      projectId,
+      status: {


Consider checking if the Op.in condition is necessary for the specific logic you are implementing. If the logic requires handling only specific statuses, ensure that the statuses included are correct and comprehensive for the intended functionality.

github-actions · 2025-07-29T20:24:27Z

src/routes/projectMembers/update.js

+  req.log.debug(`updated all copilot applications`);
+
+  const memberDetails = await util.getMemberDetailsByUserIds([_member.userId], req.log, req.id);
+  const member = memberDetails[0];


Consider adding error handling for the memberDetails array to ensure it contains elements before accessing the first element. This will prevent potential runtime errors if the array is empty.

github-actions · 2025-07-29T20:24:30Z

src/routes/projectMembers/update.js

+        opportunity_type: getCopilotTypeLabel(requestData.projectType),
+        opportunity_title: requestData.opportunityTitle,
+        start_date: moment.utc(requestData.startDate).format('DD-MM-YYYY'),
+        user_name: member ? member.handle : "",


Consider adding a null check for member before accessing member.handle to prevent potential runtime errors if member is undefined.

github-actions · 2025-07-29T20:24:30Z

src/routes/projectMembers/update.js

+        user_name: member ? member.handle : "",
+      },
+      sendgrid_template_id: TEMPLATE_IDS.COPILOT_ALREADY_PART_OF_PROJECT,
+      recipients: [member.email],


Consider adding a null check for member before accessing member.email to prevent potential runtime errors if member is undefined.

github-actions · 2025-07-29T20:24:30Z

src/routes/projectMembers/update.js

+      version: 'v3',
+    }, req.log);
+
+    req.log.debug(`Sent email to ${member.email}`);


Consider adding a null check for member before accessing member.email to prevent potential runtime errors if member is undefined.

hentrymartin added 30 commits July 23, 2025 21:54

fix: removed logic to allow inviting user even if they are already a …

25b8b34

…member

fix: allow copilots to be added even if the existing member

7831f54

fix: allow copilots to be added even if the existing member

57a8d00

fix: allow copilots to be added even if the existing member

1b21d3b

fix: allow copilots to be added even if the existing member

fa13330

fix: allow copilots to be added even if the existing member

0536910

fix: allow copilots to be added even if the existing member

b67a6ba

fix: just switch role if user is already a member

f26de03

fix: just switch role if user is already a member

50d2dac

fix: debug logs

347caae

fix: debug logs

d4e4033

fix: debug logs

ecb836c

fix: update kafka

279d2f1

fix: update kafka

3998114

revert

b7c5f95

fix: build

bebe265

fix: added error string and already assigned role

9385156

fix: added error string and already assigned role

fdb09e3

fix: added error string and already assigned role

2dc0ea2

fix: added error string and already assigned role

13c8c39

feat: modifications on copilot addition to project

f73f444

feat: modifications on copilot addition to project

7fce661

feat: modifications on copilot addition to project

1f2cba4

feat: modifications on copilot addition to project

1266652

fix: complete the copilot requests if the incoming role is observer o…

c701b1e

…r customer

fix: complete the copilot requests if the incoming role is observer o…

1d19d15

…r customer

fix: complete the copilot requests if the incoming role is observer o…

af842b0

…r customer

fix: complete the copilot requests if the incoming role is observer o…

0d02782

…r customer

fix: action string

ce575c7

fix: send email to project manager on copilot invite acceptation

2f2e162

github-actions bot reviewed Jul 28, 2025

View reviewed changes

fix: send email to project manager on copilot invite acceptation

21977ef

github-actions bot reviewed Jul 28, 2025

View reviewed changes

fix: send email to project manager on copilot invite acceptation

b4dbde5

github-actions bot reviewed Jul 28, 2025

View reviewed changes

fix: send email to project manager on copilot invite acceptation

fc0bffe

github-actions bot reviewed Jul 28, 2025

View reviewed changes

send email to copilot who got selected

ccceb70

github-actions bot reviewed Jul 29, 2025

View reviewed changes

send email to copilot who got selected

d56f233

github-actions bot reviewed Jul 29, 2025

View reviewed changes

hentrymartin added 2 commits July 29, 2025 20:11

fix: allow action to be empty string

37f740c

fix: allow action to be empty string

993ea57

github-actions bot reviewed Jul 29, 2025

View reviewed changes

hentrymartin added 2 commits July 29, 2025 20:49

fix: allow action to be empty string

b3e4f8e

fix: allow action to be empty string

45629b5

github-actions bot reviewed Jul 29, 2025

View reviewed changes

hentrymartin added 2 commits July 29, 2025 21:50

fix: allow action to be empty string

5025fa1

fix: allow action to be empty string

7075d3f

github-actions bot reviewed Jul 29, 2025

View reviewed changes

kkartunov approved these changes Jul 30, 2025

View reviewed changes

kkartunov merged commit 4a2a671 into develop Jul 30, 2025
2 checks passed


		req.log.debug(`updated all copilot applications`);

		await _transaction.commit();


		await _transaction.commit();

		const memberDetails = await util.getMemberDetailsByUserIds([_member.userId], req.log, req.id);


		req.log.debug(`Copilot request data: ${requestData}`);
		const opportunity = copilotOpportunites.find(item => item.copilotRequestId === request.id);

feat(PM-1510): Send Email notification to PM/creator once copilot accepts invite #839

feat(PM-1510): Send Email notification to PM/creator once copilot accepts invite #839

Uh oh!

Conversation

hentrymartin commented Jul 28, 2025

What's in this PR?

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!