configFactory: support entry as an array

[maxceem]

Providing entry value to configFactory as an array it's not supported.

What I did:

• Call configFactory providing an array to entry:

  configFactory({
    entry: [
      'one entry',
      'second entry'
    ]
  })
  

• In the resulting webpack config both for development and production environment I get:

  {
     entry: [
      'one entry',
      'second entry'
    ]
  }
  

• Expected output for production is:

  {
    entry: {
      main: [
        'one entry',
        'second entry'
      ],
      polyfills, [
        'babel-polyfill',
        'nodelist-foreach-polyfill',
     ]
  }
  

• and for development:

  {
    entry: {
      main: [
        'react-hot-loader/patch',
        'webpack-hot-middleware/client?reload=true',
        'one entry',
        'second entry'
      ],
      polyfills, [
        'babel-polyfill',
        'nodelist-foreach-polyfill',
     ]
  }
  

[birdofpreyru]

@maxceem are you sure you don't override the entry config at your side, ocasionally?
Cause the code block that normalizes the entry config

topcoder-react-utils/config/webpack/app-base.js

Lines 63 to 72 in 0d26207

	const entry = _.isObject(o.entry)
	? _.cloneDeep(o.entry) : { main: o.entry };
	if (!entry.polyfills) entry.polyfills = [];
	else if (!_.isArray(entry.polyfills)) {
	entry.polyfills = [entry.polyfills];
	}
	entry.polyfills = _.union(entry.polyfills, [
	'babel-polyfill',
	'nodelist-foreach-polyfill',
	]);

is supposed to support array values already.

[maxceem]

@birdofpreyru yeah, I'm sure that I didn't override that.

The thing is, that _.isObject returns true for arrays https://lodash.com/docs/4.17.4#isObject.
Thus it assigns polyfills property to an array instead of creating a new object with array assigned to main.

[birdofpreyru]

Oh... Let's replace it with _.isPlainObject(..)? It will work correct for this case. Can you think about any corner case where it may fail?

[maxceem]

Replacing with _.isPlainObject(..) sounds like a proper solution. I cannot imagine any reasonable value where it can fail.