Final Deliverables are not getting saved

[codejamtc]

8.zip

Steps to reproduce the problem

1. Open https://challenges.topcoder-dev.com/ and login as Admin
2. Select a project from the list 'Test v5 {codejam} - 0001'
3. Click 'Launch New'
4. Select Work Type=Design; Format=Challenge; Name=Test
5. Click 'Continue Set-Up'
6. Go to 'Final Deliverables'
7. Enter "JPG' and click 'Add File Type' button
8. Enter "BMP' and click 'Add File Type' button
9. Click 'Save Draft'
10. Click 'View Challenge'
11. Click 'Back'
12. Open the same challenge

Actual behavior

• Final Deliverables are not getting saved

Expected behavior

• Should have the Final Deliverables added by the user

Environment

- OS: HP 15-dw1xxx 15.6 inch; Window 10
- Browser (w/version): Chrome 85.0.4183.83
- User role (client, copilot or manager): Admin
- Account used: TonyJ

[maxceem]

@vikasrohit this data is not being saved yet to API. As per swagger, there is no special place for final deliverables or file types.
Should we put it to metadata? Can we name as we want, or is there any specification for this?

[vikasrohit]

Yes, I think we need to use metadata for that, but I am not sure if there is a defined key for that. If that information is not in swagger, we need help from @rootelement for this.

[rootelement]

Please see here:
#783 (comment)

[maxceem]

@vikasrohit using the comment from above I found an example of challenge with such data in PROD:

The only thing the current UI seems like doesn't suit well to what we need:

We have to be able to add and remove file types. At the moment when we add a file type it's added with a checkbox, which seems like doesn't bring any value.
I suggest removing the checkboxes, and add - or x button instead for each item, which would remove the file type.

[vikasrohit]

@maxceem are we setting fileTypes in the metadata?

We have to be able to add and remove file types. At the moment when we add a file type it's added with a checkbox, which seems like doesn't bring any value.

Does checking and then unchecking the checkbox not delete the file type?

I suggest removing the checkboxes, and add - or x button instead for each item, which would remove the file type.

If checkbox is doing its purpose, we can use this way for no.

[maxceem]

@vikasrohit

are we setting fileTypes in the metadata?

Not yet, this has to be fixed.

Does checking and then unchecking the checkbox not delete the file type?

No, it doesn't.

If checkbox is doing its purpose, we can use this way for no.

It feels that using checkboxes is misleading here. In the metadata, we can only store the list of data types, we don't have a way to store if type is checked or no, only if it present or no.