Skip to content

add Iterative Reviewer for First2Finish and Task type challenges #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2021
Merged

add Iterative Reviewer for First2Finish and Task type challenges #1029

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9ae916
add Iterative Reviewer for First2Finish and Task type challenges
akumar1503 Jan 9, 2021
eaf1abd
Fix initial reviewer field and do not re-post resource to server
akumar1503 Jan 11, 2021
84b4ed0
fix undefined bug
akumar1503 Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/components/ChallengeEditor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ class ChallengeEditor extends Component {
try {
const challengeId = this.getCurrentChallengeId()
// state can have updated assigned member (in cases where user changes assignments without refreshing the page)
const { challenge: { copilot, reviewer }, assignedMemberDetails: assignedMember } = this.state
const { challenge: { copilot, reviewer, type }, assignedMemberDetails: assignedMember } = this.state
const oldMemberHandle = _.get(oldAssignedMember, 'handle')
const assignedMemberHandle = _.get(assignedMember, 'handle')
// assigned member has been updated
Expand All @@ -965,8 +965,11 @@ class ChallengeEditor extends Component {
const action = await updateChallengeDetails(challengeId, challenge)
const { copilot: previousCopilot, reviewer: previousReviewer } = this.state.draftChallenge.data
if (copilot !== previousCopilot) await this.updateResource(challengeId, 'Copilot', copilot, previousCopilot)
if (reviewer !== previousReviewer) await this.updateResource(challengeId, 'Reviewer', reviewer, previousReviewer)

if (type === 'First2Finish' || type === 'Task') {
await this.updateResource(challengeId, 'Iterative Reviewer', reviewer)
} else {
if (reviewer !== previousReviewer) await this.updateResource(challengeId, 'Reviewer', reviewer, previousReviewer)
}
const draftChallenge = { data: action.challengeDetails }
draftChallenge.data.copilot = copilot
draftChallenge.data.reviewer = reviewer
Expand Down