Skip to content

fix: disable on the listing page without legacy #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

fix: disable on the listing page without legacy #945

merged 1 commit into from
Dec 9, 2020

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented Dec 8, 2020

ref issue #943

@maxceem maxceem requested a review from vikasrohit December 8, 2020 15:34
@maxceem maxceem mentioned this pull request Dec 8, 2020
Closed
vikasrohit
vikasrohit approved these changes Dec 9, 2020
View reviewed changes
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for extracting the string as constant. LGTM

@vikasrohit vikasrohit merged commit b8ba616 into topcoder-platform:develop Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vikasrohit vikasrohit vikasrohit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxceem @vikasrohit