Set up Github Actions #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mgax
commented
Oct 8, 2024
mgax
commented
- Update the Readme with syntax highlighting.
- Update PyPI links.
- Set up CI and publishing actions.
zerolab
reviewed
Oct 8, 2024
tox.ini
Outdated
| py39-django42-wagtail62 | ||
| py{39,310,311,312}-django42-wagtail62 | ||
| py{310,311,312}-django{50,51}-wagtail62 | ||
| py312-django42-wagtail{52,60,61,62} |
Member
There was a problem hiding this comment.
drive-by suggestion
Suggested change
| py312-django42-wagtail{52,60,61,62} | |
| py312-django42-wagtail{52,62} |
since 6.0 and 6.1 are no longer officially supported
other than that, I would take a more opinionated stance and do Python 3.11+ (but that is only me)
Member
Author
There was a problem hiding this comment.
Ah, good call about Wagtail versions, thanks!
I'm not sure about only supporting Python 3.11+ though. In general, I agree with the sentiment, but I can imagine somebody jumping in to rescue a legacy project, and hoping to pull the production database, without doing a major upgrade beforehand. It's a simple package, and doesn't cost us much to support older Pythons (aside from some CI time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.