-
Notifications
You must be signed in to change notification settings - Fork 2
Wagtail 7.0 Maintenance #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 7.0 Maintenance #5
Conversation
tox.ini
Outdated
| py{39,310,311,312}-django42-wagtail70 | ||
| py{310,311,312,313}-django{51,52}-wagtail70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: We are in the new position of having two LTS versions that will be supported for about the same length of time, so what do you think about adjusting the tests to include 6.3 and 7.0 in all tests?
py{39,310,311,312}-django42-wagtail{63,70}
py{310,311,312,313}-django{51,52}-wagtail{63,70}
Or, as Wagtail 5.2 has not reached EOL, would you prefer to replace it in the old LTS test:
py39-django42-wagtail63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianmeigh I prefer option 1
|
Suggestion: Bump the version of Wagtail in the optional dependencies: [project.optional-dependencies]
dev = [
# ... existing deps ...
"wagtail~=6.3",
] |
|
Include this work in the CHANGELOG. |
…ectively Also update the target version for ruff to py313
I decided to use a different syntax here as well. After some digging around |
Thanks for spotting that 👍 Updated |
ianmeigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nickmoreton, LGTM!
This pull request updates the
tox.iniconfiguration to align with the latest supported versions of Django and Wagtail.Updates to version compatibility:
envlistintox.inito include Wagtail 6.3 & Wagtail 7.0 and adjust the associated Django version ranges accordingly.[testenv]section to include Django 5.2 and Wagtail 7.0 while removing references to Django 5.0 and Wagtail 6.2.