Skip to content

Conversation

@nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented May 19, 2025

This pull request updates the tox.ini configuration to align with the latest supported versions of Django and Wagtail.

Updates to version compatibility:

  • Updated the envlist in tox.ini to include Wagtail 6.3 & Wagtail 7.0 and adjust the associated Django version ranges accordingly.
  • Updated dependency version ranges in the [testenv] section to include Django 5.2 and Wagtail 7.0 while removing references to Django 5.0 and Wagtail 6.2.

@nickmoreton nickmoreton marked this pull request as ready for review May 19, 2025 16:51
tox.ini Outdated
Comment on lines 4 to 5
py{39,310,311,312}-django42-wagtail70
py{310,311,312,313}-django{51,52}-wagtail70

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: We are in the new position of having two LTS versions that will be supported for about the same length of time, so what do you think about adjusting the tests to include 6.3 and 7.0 in all tests?

py{39,310,311,312}-django42-wagtail{63,70}
py{310,311,312,313}-django{51,52}-wagtail{63,70}

Or, as Wagtail 5.2 has not reached EOL, would you prefer to replace it in the old LTS test:

py39-django42-wagtail63

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianmeigh I prefer option 1

@ianmeigh
Copy link

Suggestion: Bump the version of Wagtail in the optional dependencies:

[project.optional-dependencies]
dev = [
   # ... existing deps ...
    "wagtail~=6.3",
]

@ianmeigh
Copy link

ianmeigh commented May 21, 2025

Include this work in the CHANGELOG.

@nickmoreton
Copy link
Contributor Author

nickmoreton commented May 22, 2025

Suggestion: Bump the version of Wagtail in the optional dependencies:
...

I decided to use a different syntax here as well. After some digging around ~= only installs that major version as far as I can tell. I did another change too to use python 3.13

@nickmoreton
Copy link
Contributor Author

Include this work in the CHANGELOG.

Thanks for spotting that 👍 Updated

@nickmoreton nickmoreton requested a review from ianmeigh May 22, 2025 11:02
Copy link

@ianmeigh ianmeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickmoreton, LGTM!

@nickmoreton nickmoreton merged commit b4fe246 into torchbox:main Oct 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants