Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15 #65

Merged
merged 1 commit into from
May 13, 2014
Merged

Fix #15 #65

merged 1 commit into from
May 13, 2014

Conversation

130s
Copy link
Contributor

@130s 130s commented May 13, 2014

Not exactly sure what solves the issue, but as noted here, rosparam set robot_description -t NextageOpen.urdf seems to be a key and that's done in the newly included .launch file.

@130s
Copy link
Contributor Author

130s commented May 13, 2014

Because of #64, travis easily passes unfavorably.

@130s
Copy link
Contributor Author

130s commented May 13, 2014

I find no significant difference in the following .launch files in hironx and nextage, other than package names being different. So it might now really be an issue of combination of the collada file and planning_context?

Let me go ahead and merge.

$ diff -w -b move_group.launch ../../../../start-jsk/rtmros_hironx/hironx_moveit_config/launch/move_group.launch 
3c3
<   <include file="$(find nextage_moveit_config)/launch/planning_context.launch" />
---
>   <include file="$(find hironx_moveit_config)/launch/planning_context.launch" />
16c16
<   <arg name="publish_monitored_planning_scene" default="true"/>
---
>   <arg name="publish_monitored_planning_scene" default="false"/>
18c18
<   <include ns="move_group" file="$(find nextage_moveit_config)/launch/planning_pipeline.launch">
---
>   <include ns="move_group" file="$(find hironx_moveit_config)/launch/planning_pipeline.launch">
22,23c22,23
<   <include ns="move_group" file="$(find nextage_moveit_config)/launch/trajectory_execution.launch" if="$(arg allow_trajectory_execution)">
<     <arg name="moveit_controller_manager" value="NextageOpen" /> 
---
>   <include ns="move_group" file="$(find hironx_moveit_config)/launch/trajectory_execution.launch" if="$(arg allow_trajectory_execution)">
>     <arg name="moveit_controller_manager" value="HiroNX" /> 
27,28c27,28
<   <include ns="move_group" file="$(find nextage_moveit_config)/launch/sensor_manager.launch" if="$(arg allow_trajectory_execution)">
<     <arg name="moveit_sensor_manager" value="NextageOpen" /> 
---
>   <include ns="move_group" file="$(find hironx_moveit_config)/launch/sensor_manager.launch" if="$(arg allow_trajectory_execution)">
>     <arg name="moveit_sensor_manager" value="HiroNX" /> 
$ diff -w -b moveit_rviz.launch ../../../../start-jsk/rtmros_hironx/hironx_moveit_config/launch/moveit_rviz.launch 9c9
<   <arg     if="$(arg config)" name="command_args" value="-d $(find nextage_moveit_config)/launch/moveit.rviz" />
---
>   <arg     if="$(arg config)" name="command_args" value="-d $(find hironx_moveit_config)/launch/moveit_viewnatto.rviz" />
11c11
<   <node name="$(anon rviz)" launch-prefix="$(arg launch_prefix)" pkg="rviz" type="rviz" respawn="false"
---
>   <node name="$(anon rviz)" launch-prefix="$(arg launch_prefix)" pkg="rviz" type="rviz" respawn="true"
13c13
<     <rosparam command="load" file="$(find nextage_moveit_config)/config/kinematics.yaml"/>
---
>     <rosparam command="load" file="$(find hironx_moveit_config)/config/kinematics.yaml"/>
$ diff -w -b moveit_planning_execution.launch ../../../../start-jsk/rtmros_hironx/hironx_moveit_config/launch/moveit_planning_execution.launch 
4,5c4,5
<  # and the current state of the world as seen by the planner.
<  <include file="$(find nextage_moveit_config)/launch/move_group.launch">
---
>  # and the current state of the world as seen by the planner
>  <include file="$(find hironx_moveit_config)/launch/move_group.launch">
9c9
<  <include file="$(find nextage_moveit_config)/launch/moveit_rviz.launch"> 
---
>  <include file="$(find hironx_moveit_config)/launch/moveit_rviz.launch"> 
12,16d11
< 
<  <include file="$(find nextage_moveit_config)/launch/planning_context.launch">
<    <arg name="load_robot_description" value="true"/>
<  </include>

130s pushed a commit that referenced this pull request May 13, 2014
@130s 130s merged commit 3d2179f into tork-a:groovy-devel May 13, 2014
@k-okada
Copy link
Member

k-okada commented May 16, 2014

So it might now really be an issue of combination of the collada file and planning_context?

Remember this might be problem for our case, @YoheiKakiuchi, @mmurooka, @garaemon

@130s 130s mentioned this pull request May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants