feat: MakeDiffParser.parse async to offload it from MainActor
#5
+236
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to merge #3 first beacuse it contains confliction |
merged |
Lets open separate PR for that |
|
I will review it soon! Thanks for opening it |
Sure. |
xinnjie
force-pushed
the
feat-async-parse
branch
from
8d41756 to
769b6e4
Compare
tornikegomareli
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete #4
Also find out that changing
VStacktoLasyVStackinDiffFileViewimproves performance when having large amount of hunks. Not sure about whether to include this change in this PR.