added export to Singleton and removed src dir #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmulry
commented
Dec 19, 2017
| // A variable which stores the singleton object. Intially, | ||
| // the variable acts like a placeholder | ||
| private static singleton: Singleton = null; | ||
| // private constructor so that no instance is created | ||
| private constructor() { | ||
| } | ||
| // This is how we create a singleton object | ||
| public static getInstance(): Singleton { |
Contributor
Author
There was a problem hiding this comment.
is the intent here to demo the typescript 'get' keyword?
torokmark
approved these changes
Dec 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error on running
tscsingleton/src/demo.ts(6,38): error TS2339: Property 'Singleton' does not exist on type 'typeof SingletonPattern'. singleton/src/demo.ts(7,38): error TS2339: Property 'Singleton' does not exist on type 'typeof SingletonPattern'.Added an export keyword and moved the singleton files up a directory. For some reason they were the only ones that use a
srcdir.