Overhaul stats: Improve torrent-repository package before adding events (part 2) #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests will be removed becuase unit tests have been added. Besides, there is no point in testing only the wrapper. SwarmHandle in only a wrapper over Swarm.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1500 +/- ##
===========================================
- Coverage 85.05% 83.75% -1.31%
===========================================
Files 258 257 -1
Lines 20546 17837 -2709
Branches 20546 17837 -2709
===========================================
- Hits 17476 14939 -2537
+ Misses 2781 2623 -158
+ Partials 289 275 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
They have been moved one level up to the InMemoryTorrentRepository type. We should buble them up to the final user, returing an error in the UDP or HTTP tracker when the swarm handle lock cannot be adquired. A new issues will be opened to address that.
It was public only to allow setting a pre-defined state in tests. A new public method have been adding temporarily to explain its usage.
Member
Author
|
ACK 4d91738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
torrent-repositorypackage before adding events.This is a continuation of tracker/issues/1495.
Refactoring
TorrentRepositorySwarmstype.swarmsprivate.lenandis_emptymethods.upsert_peer.