Skip to content

Fix ci status failing in readme #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2025
Merged

Fix ci status failing in readme #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa550f3
ci: fix ci status badge show failing
waketzheng Nov 9, 2025
ad92090
docs: update readme
waketzheng Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ env:

jobs:
test:
if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.base.repo.full_name == github.repository) }}
runs-on: ubuntu-22.04
services:
mssql:
Expand Down Expand Up @@ -68,7 +67,6 @@ jobs:
COVERALLS_PARALLEL: true

coveralls:
if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.base.repo.full_name == github.repository) }}
name: Finish Coveralls
needs: test
runs-on: ubuntu-22.04
Expand Down
5 changes: 1 addition & 4 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ asyncodbc
with asyncio_. It relies on the awesome pyodbc_ library and preserves the same look and
feel. *asyncodbc* was written using `async/await` syntax (PEP492_) and only support
Python that is not end-of-life(EOL). Internally *asyncodbc* employs threads to avoid
blocking the event loop, threads_ are not that as bad as you think!. Other
blocking the event loop, threads_ are not that as bad as you think! Other
drivers like motor_ use the same approach.

**asyncodbc** is fully compatible and tested with uvloop_. Take a look at the test
Expand Down Expand Up @@ -39,7 +39,6 @@ Properties are unchanged, so ``conn.prop`` is correct as well as
import asyncio
import asyncodbc


async def test_example():
dsn = 'Driver=SQLite;Database=sqlite.db'
conn = await asyncodbc.connect(dsn=dsn, loop=loop)
Expand All @@ -65,7 +64,6 @@ Connection pooling is ported from aiopg_ and relies on PEP492_ features:
import asyncio
import asyncodbc


async def test_pool():
dsn = 'Driver=SQLite;Database=sqlite.db'
pool = await asyncodbc.create_pool(dsn=dsn, loop=loop)
Expand Down Expand Up @@ -93,7 +91,6 @@ protocol:
import asyncio
import asyncodbc


async def test_example():
dsn = 'Driver=SQLite;Database=sqlite.db'

Expand Down