Skip to content

Commit 24e2103

Browse files
onenowySasha Levin
authored andcommitted
Revert "usb: storage: Add quirk for Samsung Fit flash"
[ Upstream commit ad5dbfc ] This reverts commit 86d92f5, which fix the timeout issue for "Samsung Fit Flash". But the commit affects not only "Samsung Fit Flash" but also other usb storages that use the same controller and causes severe performance regression. # hdparm -t /dev/sda (without the quirk) Timing buffered disk reads: 622 MB in 3.01 seconds = 206.66 MB/sec # hdparm -t /dev/sda (with the quirk) Timing buffered disk reads: 220 MB in 3.00 seconds = 73.32 MB/sec The commit author mentioned that "Issue was reproduced after device has bad block", so this quirk should be applied when we have the timeout issue with a device that has bad blocks. We revert the commit so that we apply this quirk by adding kernel paramters using a bootloader or other ways when we really need it, without the performance regression with devices that don't have the issue. Signed-off-by: sunghwan jung <onenowy@gmail.com> Link: https://lore.kernel.org/r/20220913114913.3073-1-onenowy@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 77b6bd1 commit 24e2103

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/usb/storage/unusual_devs.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1275,12 +1275,6 @@ UNUSUAL_DEV( 0x090a, 0x1200, 0x0000, 0x9999,
12751275
USB_SC_RBC, USB_PR_BULK, NULL,
12761276
0 ),
12771277

1278-
UNUSUAL_DEV(0x090c, 0x1000, 0x1100, 0x1100,
1279-
"Samsung",
1280-
"Flash Drive FIT",
1281-
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
1282-
US_FL_MAX_SECTORS_64),
1283-
12841278
/* aeb */
12851279
UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff,
12861280
"Feiya",

0 commit comments

Comments
 (0)