Skip to content

Commit 29dcc16

Browse files
Stanislav KinsburskyTrond Myklebust
authored andcommitted
NFS: make nfs_callback_tcpport6 per network context
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
1 parent bbe0a3a commit 29dcc16

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

fs/nfs/callback.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ static struct nfs_callback_data nfs_callback_info[NFS4_MAX_MINOR_VERSION + 1];
3838
static DEFINE_MUTEX(nfs_callback_mutex);
3939
static struct svc_program nfs4_callback_program;
4040

41-
unsigned short nfs_callback_tcpport6;
42-
4341
static int nfs4_callback_up_net(struct svc_serv *serv, struct net *net)
4442
{
4543
int ret;
@@ -56,9 +54,9 @@ static int nfs4_callback_up_net(struct svc_serv *serv, struct net *net)
5654
ret = svc_create_xprt(serv, "tcp", net, PF_INET6,
5755
nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS);
5856
if (ret > 0) {
59-
nfs_callback_tcpport6 = ret;
57+
nn->nfs_callback_tcpport6 = ret;
6058
dprintk("NFS: Callback listener port = %u (af %u, net %p)\n",
61-
nfs_callback_tcpport6, PF_INET6, net);
59+
nn->nfs_callback_tcpport6, PF_INET6, net);
6260
} else if (ret != -EAFNOSUPPORT)
6361
goto out_err;
6462
return 0;

fs/nfs/callback.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,5 @@ extern int nfs4_set_callback_sessionid(struct nfs_client *clp);
208208
#define NFS41_BC_MAX_CALLBACKS 1
209209

210210
extern unsigned int nfs_callback_set_tcpport;
211-
extern unsigned short nfs_callback_tcpport6;
212211

213212
#endif /* __LINUX_FS_NFS_CALLBACK_H */

fs/nfs/netns.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ struct nfs_net {
2323
#if IS_ENABLED(CONFIG_NFS_V4)
2424
struct idr cb_ident_idr; /* Protected by nfs_client_lock */
2525
unsigned short nfs_callback_tcpport;
26+
unsigned short nfs_callback_tcpport6;
2627
#endif
2728
spinlock_t nfs_client_lock;
2829
struct timespec boot_time;

fs/nfs/nfs4state.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ int nfs4_init_clientid(struct nfs_client *clp, struct rpc_cred *cred)
8080
goto do_confirm;
8181
port = nn->nfs_callback_tcpport;
8282
if (clp->cl_addr.ss_family == AF_INET6)
83-
port = nfs_callback_tcpport6;
83+
port = nn->nfs_callback_tcpport6;
8484

8585
status = nfs4_proc_setclientid(clp, NFS4_CALLBACK, port, cred, &clid);
8686
if (status != 0)

0 commit comments

Comments
 (0)