Skip to content

Commit 2a4cc2a

Browse files
ppetter1025Sasha Levin
authored andcommitted
drm/bridge: it6505: Fix the order of DP_SET_POWER commands
[ Upstream commit 7c1dcea ] Send DP_SET_POWER_D3 command to the downstream before stopping DP, so the suspend process will not be interrupted by the HPD interrupt. Also modify the order in .atomic_enable callback to make the callbacks symmetric. Fixes: 46ca7da ("drm/bridge: it6505: Send DPCD SET_POWER to downstream") Signed-off-by: Pin-yen Lin <treapking@chromium.org> Reviewed-by: Robert Foss <robert.foss@linaro.org> Signed-off-by: Robert Foss <robert.foss@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220830045756.1655954-1-treapking@chromium.org Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 84b7de6 commit 2a4cc2a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/bridge/ite-it6505.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2945,9 +2945,6 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
29452945
if (ret)
29462946
dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
29472947

2948-
it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
2949-
DP_SET_POWER_D0);
2950-
29512948
it6505_update_video_parameter(it6505, mode);
29522949

29532950
ret = it6505_send_video_infoframe(it6505, &frame);
@@ -2957,6 +2954,9 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
29572954

29582955
it6505_int_mask_enable(it6505);
29592956
it6505_video_reset(it6505);
2957+
2958+
it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
2959+
DP_SET_POWER_D0);
29602960
}
29612961

29622962
static void it6505_bridge_atomic_disable(struct drm_bridge *bridge,
@@ -2968,9 +2968,9 @@ static void it6505_bridge_atomic_disable(struct drm_bridge *bridge,
29682968
DRM_DEV_DEBUG_DRIVER(dev, "start");
29692969

29702970
if (it6505->powered) {
2971-
it6505_video_disable(it6505);
29722971
it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
29732972
DP_SET_POWER_D3);
2973+
it6505_video_disable(it6505);
29742974
}
29752975
}
29762976

0 commit comments

Comments
 (0)