Skip to content

Commit 2f22b41

Browse files
committed
drm/file: Don't set master on in-kernel clients
It only makes sense for userspace clients. Signed-off-by: Noralf Trønnes <noralf@tronnes.org> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20180618141739.48151-3-noralf@tronnes.org
1 parent 32a0d70 commit 2f22b41

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/gpu/drm/drm_file.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -155,17 +155,8 @@ struct drm_file *drm_file_alloc(struct drm_minor *minor)
155155
goto out_prime_destroy;
156156
}
157157

158-
if (drm_is_primary_client(file)) {
159-
ret = drm_master_open(file);
160-
if (ret)
161-
goto out_close;
162-
}
163-
164158
return file;
165159

166-
out_close:
167-
if (dev->driver->postclose)
168-
dev->driver->postclose(dev, file);
169160
out_prime_destroy:
170161
if (drm_core_check_feature(dev, DRIVER_PRIME))
171162
drm_prime_destroy_file_private(&file->prime);
@@ -365,6 +356,7 @@ static int drm_open_helper(struct file *filp, struct drm_minor *minor)
365356
{
366357
struct drm_device *dev = minor->dev;
367358
struct drm_file *priv;
359+
int ret;
368360

369361
if (filp->f_flags & O_EXCL)
370362
return -EBUSY; /* No exclusive opens */
@@ -379,6 +371,14 @@ static int drm_open_helper(struct file *filp, struct drm_minor *minor)
379371
if (IS_ERR(priv))
380372
return PTR_ERR(priv);
381373

374+
if (drm_is_primary_client(priv)) {
375+
ret = drm_master_open(priv);
376+
if (ret) {
377+
drm_file_free(priv);
378+
return ret;
379+
}
380+
}
381+
382382
filp->private_data = priv;
383383
filp->f_mode |= FMODE_UNSIGNED_OFFSET;
384384
priv->filp = filp;

0 commit comments

Comments
 (0)