Skip to content

Commit 5338601

Browse files
dinghaoliuchombourger
authored andcommitted
video: fbdev: radeon: Fix memleak in radeonfb_pci_register
[ Upstream commit fe6c6a4 ] When radeon_kick_out_firmware_fb() fails, info should be freed just like the subsequent error paths. Fixes: 069ee21 ("fbdev: Fix loading of module radeonfb on PowerMac") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Mathieu Malaterre <malat@debian.org> Cc: Kangjie Lu <kjlu@umn.edu> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200825062900.11210-1-dinghao.liu@zju.edu.cn Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 3190ac6 commit 5338601

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/video/fbdev/aty/radeon_base.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2327,7 +2327,7 @@ static int radeonfb_pci_register(struct pci_dev *pdev,
23272327

23282328
ret = radeon_kick_out_firmware_fb(pdev);
23292329
if (ret)
2330-
return ret;
2330+
goto err_release_fb;
23312331

23322332
/* request the mem regions */
23332333
ret = pci_request_region(pdev, 0, "radeonfb framebuffer");

0 commit comments

Comments
 (0)