Skip to content

Commit 836676b

Browse files
committed
drm/mediatek: dsi: provide LP-11 mode during .pre_enable
As per specification in drivers/gpu/drm/drm_bridge.c the data lanes should be in LP-11 mode after .pre_enable() has been run. HS mode of the data lanes are enabled with mtk_dsi_start(). Therefore, move that call to the .enable() callback. Signed-off-by: Michael Walle <mwalle@kernel.org>
1 parent b8b2531 commit 836676b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/gpu/drm/mediatek/mtk_dsi.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -738,8 +738,6 @@ static void mtk_output_dsi_enable(struct mtk_dsi *dsi)
738738
mtk_dsi_set_mode(dsi);
739739
mtk_dsi_clk_hs_mode(dsi, 1);
740740

741-
mtk_dsi_start(dsi);
742-
743741
dsi->enabled = true;
744742
}
745743

@@ -786,7 +784,7 @@ static void mtk_dsi_bridge_atomic_enable(struct drm_bridge *bridge,
786784
if (dsi->refcount == 0)
787785
return;
788786

789-
mtk_output_dsi_enable(dsi);
787+
mtk_dsi_start(dsi);
790788
}
791789

792790
static void mtk_dsi_bridge_atomic_pre_enable(struct drm_bridge *bridge,
@@ -798,6 +796,9 @@ static void mtk_dsi_bridge_atomic_pre_enable(struct drm_bridge *bridge,
798796
ret = mtk_dsi_poweron(dsi);
799797
if (ret < 0)
800798
DRM_ERROR("failed to power on dsi\n");
799+
800+
/* Enter LP-11 state */
801+
mtk_output_dsi_enable(dsi);
801802
}
802803

803804
static void mtk_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge,

0 commit comments

Comments
 (0)