iommufd/selftest: Add asserts testing global mfd

nicolinc · pull[bot] · commit 84d3029f3bba · 2025-07-02T19:37:06.000Z
The mfd and mfd_buffer will be used in the tests directly without an extra check. Test them in setup_sizes() to ensure they are safe to use. Fixes: 0bcceb1 ("iommufd: Selftest coverage for IOMMU_IOAS_MAP_FILE") Link: https://patch.msgid.link/r/94bdc11d2b6d5db337b1361c5e5fce0ed494bb40.1750787928.git.nicolinc@nvidia.com Cc: stable@vger.kernel.org Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selftests/iommu/iommufd.c
@@ -54,6 +54,8 @@ static __attribute__((constructor)) void setup_sizes(void)
 
 	mfd_buffer = memfd_mmap(BUFFER_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED,
 				&mfd);
+	assert(mfd_buffer != MAP_FAILED);
+	assert(mfd > 0);
 }
 
 FIXTURE(iommufd)

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,8 @@ static __attribute__((constructor)) void setup_sizes(void)`
`54`	`54`
`55`	`55`	`mfd_buffer = memfd_mmap(BUFFER_SIZE, PROT_READ \| PROT_WRITE, MAP_SHARED,`
`56`	`56`	`&mfd);`
	`57`	`+ assert(mfd_buffer != MAP_FAILED);`
	`58`	`+ assert(mfd > 0);`
`57`	`59`	`}`
`58`	`60`
`59`	`61`	`FIXTURE(iommufd)`