Skip to content

Commit f0a5157

Browse files
sashalevinrostedt
authored andcommitted
tracing: Don't make assumptions about length of string on task rename
While the dest comm string size is assured to be at least TASK_COMM_LEN long, doing a memcpy() also adds the assumption that the source is at least that long as well, which isn't assured, and isn't true in cases such as: set_task_comm(worker->task, "kworker/dying"); This leads to accessing invalid memory. Link: http://lkml.kernel.org/r/1440760018-1557-1-git-send-email-sasha.levin@oracle.com Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent 9f61668 commit f0a5157

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/trace/events/task.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ TRACE_EVENT(task_rename,
4646
TP_fast_assign(
4747
__entry->pid = task->pid;
4848
memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN);
49-
memcpy(entry->newcomm, comm, TASK_COMM_LEN);
49+
strlcpy(entry->newcomm, comm, TASK_COMM_LEN);
5050
__entry->oom_score_adj = task->signal->oom_score_adj;
5151
),
5252

0 commit comments

Comments
 (0)