Skip to content

Conversation

@markmetcalfe
Copy link
Member

@markmetcalfe markmetcalfe commented Sep 18, 2025

This PR adds composer to the PHP 7.3+ containers, and also fixes a build issue with PHP 8.4.

To test this:

  1. Check out this PR
  2. Run:
    for v in php-7.3 php-7.4 php-8.0 php-8.1 php-8.2 php-8.3 php-8.4; do
        tbuild "$v" && tup "$v" && texec "$v" composer --version
    done
    and make sure there are no errors

@markmetcalfe markmetcalfe force-pushed the update-php-dockerfiles branch 4 times, most recently from d06b55e to d0521b4 Compare September 18, 2025 22:45
@markmetcalfe markmetcalfe changed the title Add composer to php images and add tests in build Add composer to php images Sep 18, 2025
@LinnyTheDuck LinnyTheDuck self-requested a review September 19, 2025 00:14
Copy link
Contributor

@LinnyTheDuck LinnyTheDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working, LGTM

@markmetcalfe markmetcalfe merged commit 935b3af into totara:develop Sep 19, 2025
@markmetcalfe markmetcalfe deleted the update-php-dockerfiles branch September 19, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants