setup script renamed; new setup script for all versions of xcode but 11 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpgalligan
reviewed
Jul 14, 2020
Collaborator
kpgalligan
left a comment
kpgalligan
left a comment
There was a problem hiding this comment.
Install docs need updates. As I understand the non-11 situation, the color file can be installed without sudo, so that should be added to the main setup script, tested, and docs updated.
setup.sh
Outdated
| ################### | ||
|
|
||
| if [ ! -d "$spec_dir" ]; then | ||
| mkdir $spec_dir |
Collaborator
There was a problem hiding this comment.
Makes the dir but doesn't actually copy any files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.