Fix RunResult unicode repr errors #1264
Conversation
| if six.PY2: | ||
| return res.encode("UTF-8") | ||
| else: | ||
| return res |
There was a problem hiding this comment.
can you make it one return?
There was a problem hiding this comment.
one less line
if six.PY2:
res = res.encode("UTF-8")
return res
There was a problem hiding this comment.
if else is easier for humans to parse as it's clearer that there are two disparate branches -- for maintenance reasons it's also easier to update if functionality were to be added as it's clearer it needs to happen at two places at a glance.
I've seen too many bugs from using your suggested style 😆
There was a problem hiding this comment.
something must be wrong with me then because for me two returns are a lot harder to understand, reason and parse 🤔 I think it's harder to maintain as now I need to update in two locations while I can clearly reduce the second to one, needing to worry only about a single case...
There was a problem hiding this comment.
your suggested pattern also makes mypy unhappy since it changes the type of the variable
Incompatible types in assignment (expression has type "bytes", variable has type "str")
There was a problem hiding this comment.
lol it's always something >.<
There was a problem hiding this comment.
it worked a while back now it's missing 💭
There was a problem hiding this comment.
microsoft/azure-pipelines-tasks#9962 turns out the ability to upload coverage report was removed 😆
There was a problem hiding this comment.
|
Seems a flaky test 😢 |
2 participants
No description provided.