Skip to content

allow passing unknown args to provisioned tox #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2019
Merged

allow passing unknown args to provisioned tox #1282

merged 1 commit into from
May 1, 2019

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented May 1, 2019 •
edited
Loading

Resolves #1270.

@gaborbernat gaborbernat changed the title allow passing unknown args to provisioned toxtox ignores unknown CLI arguments when provisioning is on and outside allow passing unknown args to provisioned toxt May 1, 2019
@gaborbernat gaborbernat changed the title allow passing unknown args to provisioned toxt allow passing unknown args to provisioned tox May 1, 2019
asottile
asottile approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat
allow passing unknown args to provisioned tox
dbd9553 
tox ignores unknown CLI arguments when provisioning is on and outside
of the provisioned environment (allowing provisioning arguments to be
forwarded freely)
@gaborbernat gaborbernat merged commit 12eb2b6 into tox-dev:master May 1, 2019
@gaborbernat gaborbernat deleted the provision-cli-args branch May 1, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obestwalter obestwalter Awaiting requested review from obestwalter

1 more reviewer

@asottile asottile asottile approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

auto-provision not compatible with new cli args

2 participants

@gaborbernat @asottile