Skip to content

Conversation

mgedmin
Copy link
Contributor

@mgedmin mgedmin commented Jul 8, 2019

depends and parallel_show_output are not global settings, they're per-environment settings. I think they got listed in the global settings section by accident.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s) – not applicable
  • updated/extended the documentation
  • added relevant issue keyword in message body – not applicable
  • added news fragment in changelog folder -- is this needed for this trivial docs fix?
  • added yourself to CONTRIBUTORS (preserving alphabetical order) -- I think I'm already there from before

`depends` and `parallel_show_output` are not global settings, they're per-environment settings.  I think they got listed in the global settings section by accident.
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@asottile
Copy link
Contributor

asottile commented Jul 8, 2019

CI is failing but will be fixed by #1364 -- this also doesn't need a changelog entry so merging!

@asottile asottile merged commit e4c7752 into tox-dev:master Jul 8, 2019
@mgedmin mgedmin deleted the patch-1 branch July 8, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants