Skip to content

Conversation

asottile
Copy link
Contributor

accidentally broken in #1380

I also made tox support environment specifiers in the requires section

unfortunately, I still can't use that in the testsuite itself because tox tries to install tox which goes to public pypi and ends up with the current version which doesn't support environment specifiers 🤦‍♂.
instead of trying to move around the testing code for the tox wheel, I opted for a comment with clean up instructions 🤷‍♂

@gaborbernat
Copy link
Member

I have a test somewhere that injects a devpi server part of the test suite, that way tox installing itself actually installs itself, not upstream itself.

@asottile
Copy link
Contributor Author

I have a test somewhere that injects a devpi server part of the test suite, that way tox installing itself actually installs itself, not upstream itself.

yeah I saw that code but didn't want to rework the whole provision tests to incorporate that for what is essentially a temporary hack -- the other provision tests have this in place and it seems to be quite a bit of work :S

@gaborbernat
Copy link
Member

Overall it is, but made it a fixture so if you just request the fixture all should automatically work 🤔

@asottile
Copy link
Contributor Author

Overall it is, but made it a fixture so if you just request the fixture all should automatically work 🤔

oh! where is it?

@asottile
Copy link
Contributor Author

I'm going to merge this for now to unblock the testsuite -- we can use that fixture later 👍

@asottile asottile merged commit 57f8cc2 into tox-dev:master Jul 27, 2019
@asottile asottile deleted the fix_testsuite branch July 27, 2019 20:53
@gaborbernat
Copy link
Member

gaborbernat commented Jul 27, 2019

Damn is in one of rewrite branches 🤕 Maybe later we add it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants