Merged
Conversation
Closed
toy
reviewed
Nov 17, 2024
lib/image_optim/worker/svgo.rb
Outdated
Comment on lines
+25
to
+28
| '`0`..`10`, ignored in default/lossless mode') \ | ||
| do |v, opt_def| | ||
| if allow_lossy | ||
| OptionHelpers.limit_with_range(v.to_i, 0..10) |
Owner
There was a problem hiding this comment.
svgo allows precision to be from 0 to 20. I'm wondering why are negative numbers forbidden (to round integer part), but that is a question to svgo.
toy
reviewed
Nov 17, 2024
Owner
toy
left a comment
toy
left a comment
There was a problem hiding this comment.
Thank you! Just notes about range of values and the changelog entry
CHANGELOG.markdown
Outdated
|
|
||
| ## unreleased | ||
|
|
||
| * Added `svgo-allow-lossy` and `svgo-precision` options to use svgo in lossy mode. This sets svgo `precision`, which can result in substantially smaller svgs. Lower values are more lossy. 3 is the default, but many SVGs will work well even with 0 or 1. [#210] [@gurgeous](https://github.com/gurgeous) |
Owner
There was a problem hiding this comment.
I think it is better to use complete option names --svgo-precision, also I assume default is to use global --allow-lossy instead of per worker --xxx-allow-lossy.
And please create complete link to #210, so it works even outside of github and please add a link to this PR too.
Owner
|
Just to post somewhere an experiment in scales accepted in svg, images should be identical because viewbox and all values inside are scaled by same power of 10, but they are not at extremes. require 'bigdecimal'
template = <<SVG
<svg xmlns="http://www.w3.org/2000/svg" width="100" height="100" viewBox="0 0 N N">
<rect x=".1N" y=".1N" width=".8N" height=".8N" fill="#777" />
<circle cx=".5N" cy=".5N" r=".5N" fill="#000" opacity=".5" />
</svg>
SVG
(-9..9).each do |power|
mult = Rational(10) ** power
File.open("#{power}.svg", 'w') do |f|
f << template.gsub(/(\.\d+)?N/) do
(BigDecimal($1 || 1) * mult).to_s('F')
end
end
end
|
Contributor
Author
|
Oh, that's neat. Appreciate the stats. Typically when I export an SVG from figma or whatever there are many extra digits. It's just the nature of the beast. Here is an actual export from one of my projects (below). I'll update the PR too :) Original (3.4k):
After svgo -p1 (1.4k):
Or even svgo -p0 (0.9k):
|
Owner
|
I forgot also to ask to run |
Contributor
Author
|
Ah, ok. Ran it! |
Owner
|
Lower case |
Closed
Contributor
Author
|
Excellent, thanks! Really appreciate all your hard work on the gem. |
Owner
|
Just released v0.31.4 |
tomhughes
pushed a commit
to tomhughes/image_optim
that referenced
this pull request
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How about this? Personally I'd suggest --precision=1 as the default since this is what I've always used. Sometimes even zero! I don't have a strong preference, though, since picky users like me can easily override :)
I added a simple test too. There is a failing spec but I don't think it's related. Feedback welcome