Skip to content

fix: EmbedCode now reflects the updated code, remove EditOnPlayground#32

Merged
DavianYang merged 1 commit intomainfrom
fix/embed-code
Jun 3, 2021
Merged

fix: EmbedCode now reflects the updated code, remove EditOnPlayground#32
DavianYang merged 1 commit intomainfrom
fix/embed-code

Conversation

@jeffydc
Copy link
Copy Markdown
Contributor

@jeffydc jeffydc commented Jun 3, 2021

Description

  • EmbedCode now copied the updated url
  • Removed EditOnPlayground in favor of the share button

fix #29 fix #30

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

- EmbedCode now copied the updated url
- Removed `EditOnPlayground` in favor of the share button

fix #29 fix #30
@jeffydc jeffydc added the bug Something isn't working label Jun 3, 2021
@jeffydc jeffydc requested a review from DavianYang June 3, 2021 12:40
@jeffydc jeffydc changed the title fix: EmbedCode now reflects the updated code fix: EmbedCode now reflects the updated code, remove EditOnPlayground Jun 3, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 3, 2021

✔️ Deploy Preview for python-playground ready!

🔨 Explore the source changes: d5d7e5f

🔍 Inspect the deploy log: https://app.netlify.com/sites/python-playground/deploys/60b8cdc910fc00000777a43d

😎 Browse the preview: https://deploy-preview-32--python-playground.netlify.app/

@DavianYang DavianYang merged commit f57dce4 into main Jun 3, 2021
@DavianYang DavianYang deleted the fix/embed-code branch June 3, 2021 13:08
@jeffydc
Copy link
Copy Markdown
Contributor Author

jeffydc commented Jun 3, 2021

We better exclude python.json as it can be generated wrongly if not Python 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EmbedCode doesn't have the changed code EditOnPlayground doesn't reflect the changed code

2 participants