-
Notifications
You must be signed in to change notification settings - Fork 48
WRITER integration support #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded a new WRITER row to the LLM Foundation Models table in openllmetry/tracing/supported.mdx, indicating Python and TypeScript support, placed after HuggingFace Transformers. No other files or behaviors changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 9ce5870 in 26 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. openllmetry/tracing/supported.mdx:29
- Draft comment:
Added WRITER integration documentation. Verify that its placement in the LLM table follows the intended order and that support in both Python and Typescript is accurate. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_5BOkzPxUAySfowWz
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
openllmetry/tracing/supported.mdx (1)
29-29: Use brand-correct casing: “Writer” (not all caps).Matches brand style used elsewhere in the table (e.g., “OpenAI”, “Groq”) and improves consistency.
-| [WRITER](https://writer.com/) | ✅ | ✅ | +| [Writer](https://writer.com/) | ✅ | ✅ |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
openllmetry/tracing/supported.mdx(1 hunks)
🔇 Additional comments (1)
openllmetry/tracing/supported.mdx (1)
29-29: Replace WRITER homepage with their SDK docs & confirm Python/TS supportNo local Writer integration page found — update openllmetry/tracing/supported.mdx to link to Writer’s SDK documentation and ensure both the Python and TypeScript (Node) columns are correct; Writer publishes official Python and Node/TypeScript SDKs. (dev.writer.com)
Important
Add WRITER to supported LLM Foundation Models in
supported.mdx.WRITERto the list of supported LLM Foundation Models insupported.mdxwith both Python and Typescript support.This description was created by
for 9ce5870. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit