-
Notifications
You must be signed in to change notification settings - Fork 46
chore(ci): fix lerna release for otel v1 #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe GitHub Actions workflow for the otel-v1 release updates the publish step to use “lerna publish from-package” instead of “from-git,” keeping existing flags unchanged. This changes version sourcing from git tags to package.json during the publish process. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Lerna as Lerna
participant NPM as npm Registry
Dev->>GH: Trigger release-otel-v1 workflow
GH->>Lerna: lerna publish from-package<br/>--dist-tag otel-v1 --no-private --yes
Lerna->>NPM: Publish packages using versions in package.json
NPM-->>GH: Publish results
GH-->>Dev: Workflow completion status
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to c3009c6 in 39 seconds. Click for details.
- Reviewed
10lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/release-otel-v1.yml:53
- Draft comment:
Using 'from-package' suggests packages are pre-versioned (via lerna version) before publishing. Confirm this is intentional for the OTel v1 release strategy. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_jsR0agU8lMkqGsmb
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Important
Change
lerna publishcommand in CI workflow to usefrom-packageinstead offrom-git..github/workflows/release-otel-v1.yml, changelerna publishcommand fromfrom-gittofrom-packageto publish packages withotel-v1dist-tag.This description was created by
for c3009c6. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit