Skip to content

Conversation

@galkleinman
Copy link
Contributor

@galkleinman galkleinman commented Aug 18, 2025

Important

Change lerna publish command in CI workflow to use from-package instead of from-git.

  • CI Workflow:
    • In .github/workflows/release-otel-v1.yml, change lerna publish command from from-git to from-package to publish packages with otel-v1 dist-tag.

This description was created by Ellipsis for c3009c6. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Updated the release process for the otel-v1 channel to determine package versions from package manifests rather than git tags, keeping existing distribution tags and publish options unchanged.
    • Improves consistency of published versions and reduces dependency on repository tagging.
    • No functional or UI changes; end users may only notice adjusted version numbering in newly published packages.

@coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The GitHub Actions workflow for the otel-v1 release updates the publish step to use “lerna publish from-package” instead of “from-git,” keeping existing flags unchanged. This changes version sourcing from git tags to package.json during the publish process.

Changes

Cohort / File(s) Summary
CI Workflow
​.github/workflows/release-otel-v1.yml
Update publish step: switch Lerna command from publish from-git to publish from-package; retain --dist-tag otel-v1 --no-private --yes.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as Developer
  participant GH as GitHub Actions
  participant Lerna as Lerna
  participant NPM as npm Registry

  Dev->>GH: Trigger release-otel-v1 workflow
  GH->>Lerna: lerna publish from-package<br/>--dist-tag otel-v1 --no-private --yes
  Lerna->>NPM: Publish packages using versions in package.json
  NPM-->>GH: Publish results
  GH-->>Dev: Workflow completion status
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump the ground: “Release, alright!”
From tags to packages—set for flight.
Carrots queued, the registry’s nigh,
Dist-tag otel-v1 hops by.
With twitching nose and whiskers bright,
I ship these bytes into the night. 🥕🚀

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 00cd7a0 and c3009c6.

📒 Files selected for processing (1)
  • .github/workflows/release-otel-v1.yml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gk/fix-otel-1-lerna-release

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@galkleinman galkleinman merged commit 0d30498 into main Aug 18, 2025
4 of 5 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to c3009c6 in 39 seconds. Click for details.
  • Reviewed 10 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/release-otel-v1.yml:53
  • Draft comment:
    Using 'from-package' suggests packages are pre-versioned (via lerna version) before publishing. Confirm this is intentional for the OTel v1 release strategy.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_jsR0agU8lMkqGsmb

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants