Skip to content

Fix full URL issue in createApiGatewayClientCredentials #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix full URL issue in createApiGatewayClientCredentials #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/Authentication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,32 +141,29 @@ public static function createOwnerCredentials(
/**
* Creates a new instance of Authentication for Client Credentials grant type
*
* @param string $clientId The oauth client id
* @param string $clientSecret The oauth client secret
* @param string $authUrl The oauth auth url
* @param string $tokenResource The access token resource of the API
* @param string $clientId The oauth client id
* @param string $clientSecret The oauth client secret
* @param string $authUrl The oauth auth url
*
* @return Authentication
*/
public static function createApiGatewayClientCredentials(
string $clientId,
string $clientSecret,
string $authUrl,
string $tokenResource = 'token'
string $authUrl
) : Authentication {
$getTokenRequestFunc = function (
string $unusedBaseUrl,
string $unusedRefreshToken = null
) use (
$clientId,
$clientSecret,
$authUrl,
$tokenResource
$authUrl
) {
$data = ['client_id' => $clientId, 'client_secret' => $clientSecret, 'grant_type' => 'client_credentials'];
return new Request(
'POST',
"{$authUrl}/oauth2/{$tokenResource}",
$authUrl,
['Content-Type' => 'application/x-www-form-urlencoded'],
Http::buildQueryString($data)
);
Expand Down
2 changes: 1 addition & 1 deletion tests/AuthenticationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public function getTokenRequestApiGatewayClientCredentials()
{
$auth = Authentication::createApiGatewayClientCredentials('id', 'secret', 'authUrl');
$request = $auth->getTokenRequest('baseUrl');
$this->assertSame('authUrl/oauth2/token', (string)$request->getUri());
$this->assertSame('authUrl', (string)$request->getUri());
$this->assertSame('POST', $request->getMethod());
$this->assertSame(
'client_id=id&client_secret=secret&grant_type=client_credentials',
Expand Down
Loading